This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Test is_inherent_required #8002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bkchr
approved these changes
Jan 29, 2021
Co-authored-by: Bastian Köcher <[email protected]>
bkchr
added
A2-insubstantial
gui1117
reviewed
Jan 29, 2021
gui1117
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
- apart from https://github.com/paritytech/substrate/pull/8002/files#r566844567 looks good to me
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
can you merge master to make CI happy ? |
|
bot merge |
|
Error getting organization membership: Status code: 404 Not Found |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @JoshOrndorff
Follow up for #7941 to verify
is_inherent_requiredimplementations that returnOk(Some(Err))require the given inherent in every block; if it is not present in a block, thencheck_extrinsicsreturns the inner error.The changes make it mandatory to include the
Extrinsic { function: Call::Test2(CallTest2::Something) }in every (test) block. If it is not included in a block, the error is returned.original problem
We need to ensure that a storage value is set every block. Right now, we do that by panicking in
on_finalizeif the storage value isn't set. This panic is redundant ifis_inherent_required -> Ok(Some(Err))enforces that an inherent which sets the given storage item is included in every block.